Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(Message): remove & this from #inGuild typeguard #8704

Merged
merged 3 commits into from Oct 5, 2022

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Fixes some intersections resolving to never.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Oct 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Oct 5, 2022 at 5:27PM (UTC)

@vladfrangu
Copy link
Member

Can ya add a test for this so we're sure it doesn't repeat? 🙏

@suneettipirneni
Copy link
Member Author

Can ya add a test for this so we're sure it doesn't repeat? 🙏

Done

@vercel vercel bot temporarily deployed to Preview October 5, 2022 17:27 Inactive
@iCrawl iCrawl merged commit c0f7a1a into discordjs:main Oct 5, 2022
@suneettipirneni suneettipirneni deleted the fix/message-in-guild-type branch October 5, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants