Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Utils): remove private from parseEmoji #8718

Merged
merged 3 commits into from Oct 9, 2022
Merged

Conversation

JPBM135
Copy link
Contributor

@JPBM135 JPBM135 commented Oct 7, 2022

Please describe the changes this PR makes and why it should be merged:

This PR removes the @private declaration from the parse emoji function. This function is very useful now that components require an APIEmoji object!

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Oct 9, 2022 at 9:17PM (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview Oct 9, 2022 at 9:17PM (UTC)

@Jiralite Jiralite added this to the discord.js v14.6 milestone Oct 7, 2022
@JPBM135 JPBM135 changed the title chore(Utils): remove private from parseEmoji docs(Utils): remove private from parseEmoji Oct 7, 2022
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the typings export this, it's fine. 👍

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #8718 (7a1c035) into main (87ec392) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 7a1c035 differs from pull request most recent head a9f9668. Consider uploading reports for the commit a9f9668 to get more accurate results

@@            Coverage Diff             @@
##             main    #8718      +/-   ##
==========================================
+ Coverage   86.83%   86.86%   +0.03%     
==========================================
  Files          87       87              
  Lines        8810     8815       +5     
  Branches     1117     1117              
==========================================
+ Hits         7650     7657       +7     
+ Misses       1118     1116       -2     
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 81.53% <ø> (ø)
rest 92.07% <ø> (+<0.01%) ⬆️
util 100.00% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.83% <ø> (+0.12%) ⬆️
ws 59.89% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/rest/src/lib/utils/constants.ts 100.00% <0.00%> (ø)
...ackages/voice/src/util/generateDependencyReport.ts 0.00% <0.00%> (ø)
packages/ws/src/utils/constants.ts 85.07% <0.00%> (+1.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants