Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Components): error with unknown components #8724

Merged
merged 1 commit into from Oct 8, 2022

Conversation

1Computer1
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Fixes #8599 probably.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Oct 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Oct 8, 2022 at 6:01AM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Oct 8, 2022 at 6:01AM (UTC)

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #8724 (68567a2) into main (62332c2) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #8724      +/-   ##
==========================================
- Coverage   86.85%   86.83%   -0.03%     
==========================================
  Files          87       87              
  Lines        8811     8810       -1     
  Branches     1117     1117              
==========================================
- Hits         7653     7650       -3     
- Misses       1116     1118       +2     
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 81.53% <ø> (ø)
rest 92.06% <100.00%> (-0.01%) ⬇️
util 100.00% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.70% <0.00%> (-0.13%) ⬇️
ws 59.75% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/voice/src/util/generateDependencyReport.ts 0.00% <0.00%> (ø)
packages/rest/src/lib/utils/constants.ts 100.00% <100.00%> (ø)
packages/ws/src/utils/constants.ts 83.87% <100.00%> (-0.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iCrawl iCrawl merged commit 6fd331d into discordjs:main Oct 8, 2022
@iCrawl iCrawl added this to the discord.js v14.6 milestone Oct 8, 2022
kevinlul added a commit to DawnbrandBots/bastion-bot that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Crash when encountering unknown component
3 participants