Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow punctuation characters in context menus #8783

Merged
merged 2 commits into from Oct 31, 2022

Conversation

g-thome
Copy link
Contributor

@g-thome g-thome commented Oct 24, 2022

Please describe the changes this PR makes and why it should be merged:
Current regex validation in the context menu builder only allows - and _
Fixes #8781
Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes

@vercel
Copy link

vercel bot commented Oct 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Oct 31, 2022 at 0:19AM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Oct 31, 2022 at 0:19AM (UTC)

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting... PR this to Discord too if you want/can

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #8783 (0433d87) into main (6e348ff) will increase coverage by 0.58%.
The diff coverage is 100.00%.

❗ Current head 0433d87 differs from pull request most recent head bda8ae1. Consider uploading reports for the commit bda8ae1 to get more accurate results

@@            Coverage Diff             @@
##             main    #8783      +/-   ##
==========================================
+ Coverage   85.22%   85.81%   +0.58%     
==========================================
  Files          77       91      +14     
  Lines        6715     9254    +2539     
  Branches      877     1125     +248     
==========================================
+ Hits         5723     7941    +2218     
- Misses        953     1271     +318     
- Partials       39       42       +3     
Flag Coverage Δ
brokers 65.24% <ø> (?)
builders 100.00% <100.00%> (ø)
collection 100.00% <ø> (ø)
proxy 81.53% <ø> (ø)
rest 92.06% <ø> (?)
util 100.00% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.70% <ø> (ø)
ws 59.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/interactions/contextMenuCommands/Assertions.ts 100.00% <100.00%> (ø)
packages/brokers/src/brokers/redis/RPCRedis.ts 54.61% <0.00%> (ø)
packages/rest/src/lib/utils/utils.ts 97.81% <0.00%> (ø)
packages/rest/src/lib/errors/RateLimitError.ts 100.00% <0.00%> (ø)
packages/rest/src/lib/REST.ts 98.87% <0.00%> (ø)
packages/rest/src/lib/errors/DiscordAPIError.ts 96.42% <0.00%> (ø)
packages/rest/src/lib/RequestManager.ts 90.26% <0.00%> (ø)
packages/brokers/src/brokers/redis/PubSubRedis.ts 84.48% <0.00%> (ø)
packages/rest/src/lib/utils/constants.ts 100.00% <0.00%> (ø)
packages/rest/src/lib/errors/HTTPError.ts 100.00% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SpaceEEC SpaceEEC added blocked and removed blocked labels Oct 31, 2022
@kodiakhq kodiakhq bot merged commit b521366 into discordjs:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Invalid String Format on Builder's .setName()
6 participants