Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(Formatters): allow boolean in formatEmoji #8823

Merged
merged 2 commits into from Nov 25, 2022

Conversation

MrMythicalYT
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Fixes #8820
Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Nov 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Nov 25, 2022 at 5:36PM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Nov 25, 2022 at 5:36PM (UTC)

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #8823 (eaeffce) into main (cb77fd0) will increase coverage by 4.80%.
The diff coverage is 100.00%.

❗ Current head eaeffce differs from pull request most recent head 88a5043. Consider uploading reports for the commit 88a5043 to get more accurate results

@@            Coverage Diff             @@
##             main    #8823      +/-   ##
==========================================
+ Coverage   85.63%   90.43%   +4.80%     
==========================================
  Files          96       85      -11     
  Lines        9475     7999    -1476     
  Branches     1137     1055      -82     
==========================================
- Hits         8114     7234     -880     
+ Misses       1319      724     -595     
+ Partials       42       41       -1     
Flag Coverage Δ
brokers 65.24% <ø> (ø)
builders 98.65% <100.00%> (+<0.01%) ⬆️
collection 100.00% <ø> (ø)
proxy 81.53% <ø> (ø)
rest 91.97% <ø> (ø)
util 100.00% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.70% <ø> (ø)
ws ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/builders/src/messages/formatters.ts 100.00% <100.00%> (ø)
.../src/strategies/sharding/SimpleShardingStrategy.ts
packages/ws/src/ws/WebSocketShard.ts
packages/ws/src/ws/WebSocketManager.ts
...trategies/context/WorkerContextFetchingStrategy.ts
...es/ws/src/strategies/sharding/IShardingStrategy.ts
.../src/strategies/sharding/WorkerShardingStrategy.ts
...src/strategies/context/IContextFetchingStrategy.ts
...trategies/context/SimpleContextFetchingStrategy.ts
packages/ws/src/utils/IdentifyThrottler.ts
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit ec37f13 into discordjs:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

formatEmoji type doesn't allow an unknown boolean type
5 participants