feat: align some methods with the Set Methods proposal #8890
+99
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
almeidx
changed the title
kyranet
requested changes
Dec 1, 2022
There was a problem hiding this comment.
We should make a new PR to change the documentation a little and phase out The X method returns... from this package. It's verbose and we don't write like that anywhere else.
I'm also not fond of describe('X() tests', cb); and would rather prefer describe('X', cb);, but that'd be another PR. 😅
Also adding the blocked label to prevent accidental semver-major merges on main.
almeidx
force-pushed
the
collection/set-methods
branch
from
106881f to
69e2f6b
Compare
kyranet
approved these changes
Dec 1, 2022
vladfrangu
approved these changes
Dec 2, 2022
SpaceEEC
approved these changes
Dec 25, 2022
iCrawl
approved these changes
Jan 10, 2023
almeidx
changed the title
BREAKING CHANGE: The `intersect` method has been renamed to `intersection` BREAKING CHANGE: The `difference` method has been renamed to `symmetricDifference` BREAKING CHANGE: The `subtract` method has been renamed to `difference`
almeidx
force-pushed
the
collection/set-methods
branch
from
6049d46 to
5ff0043
Compare
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-almeidx-collection-set-methods-discordjs.vercel.app/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Stage 3 proposal:
Overview of the changes:
intersect->intersectiondifference->symmetricDifferencesubtract->differenceunionStatus and versioning classification: