Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix deprecated links #8907

Merged
merged 2 commits into from Dec 6, 2022
Merged

docs: Fix deprecated links #8907

merged 2 commits into from Dec 6, 2022

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Dec 4, 2022

Please describe the changes this PR makes and why it should be merged:
Fixes malformed links in deprecated descriptions.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Dec 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Dec 6, 2022 at 4:36PM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Dec 6, 2022 at 4:36PM (UTC)

Copy link
Contributor

@MrMythicalYT MrMythicalYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* @deprecated Use {@link Interaction#isStringSelectMenu} instead
*/
isSelectMenu() {

Shouldn't this file be updated too? Interaction#isStringSelectMenu is nonexistent

@Jiralite Jiralite changed the title docs: Fix deprecated isStringSelectMenu() link docs: Fix deprecated link Dec 4, 2022
@Jiralite Jiralite changed the title docs: Fix deprecated link docs: Fix deprecated links Dec 4, 2022
@Jiralite
Copy link
Member Author

Jiralite commented Dec 4, 2022

That seems to not work also. Expanded on this pull request to fix that (and another link) too!

@kodiakhq kodiakhq bot merged commit 976b234 into discordjs:main Dec 6, 2022
@Jiralite Jiralite deleted the patch-1 branch December 6, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants