Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add support for role connections #8930

Merged
merged 4 commits into from Dec 16, 2022

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Dec 14, 2022

Please describe the changes this PR makes and why it should be merged:

Pending next -types release.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Dec 16, 2022 at 2:16AM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Dec 16, 2022 at 2:16AM (UTC)

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #8930 (af9a260) into main (273ba45) will decrease coverage by 0.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8930      +/-   ##
==========================================
- Coverage   85.26%   84.35%   -0.91%     
==========================================
  Files          69       98      +29     
  Lines        7219     9180    +1961     
  Branches      718     1096     +378     
==========================================
+ Hits         6155     7744    +1589     
- Misses       1060     1394     +334     
- Partials        4       42      +38     
Flag Coverage Δ
brokers 65.24% <ø> (ø)
builders 98.22% <ø> (ø)
collection 100.00% <ø> (?)
proxy 77.37% <ø> (ø)
rest 91.97% <ø> (ø)
util 100.00% <ø> (?)
utilities 100.00% <ø> (?)
voice 63.77% <ø> (?)
ws 58.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/voice/src/joinVoiceChannel.ts 100.00% <0.00%> (ø)
packages/voice/src/index.ts 100.00% <0.00%> (ø)
packages/util/src/functions/lazy.ts 100.00% <0.00%> (ø)
packages/voice/src/audio/PlayerSubscription.ts 50.00% <0.00%> (ø)
packages/voice/src/audio/AudioPlayer.ts 80.95% <0.00%> (ø)
packages/util/src/types.ts 100.00% <0.00%> (ø)
packages/voice/src/VoiceConnection.ts 81.76% <0.00%> (ø)
packages/collection/src/collection.ts 100.00% <0.00%> (ø)
packages/util/src/Equatable.ts 100.00% <0.00%> (ø)
packages/voice/src/util/entersState.ts 100.00% <0.00%> (ø)
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iCrawl iCrawl merged commit 3d6fa24 into discordjs:main Dec 16, 2022
@suneettipirneni suneettipirneni deleted the core/role-connections branch December 21, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants