Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DMChannel): recipientId edge case #8950

Merged
merged 2 commits into from Dec 24, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Dec 18, 2022

Please describe the changes this PR makes and why it should be merged:
Apparently, the first user in the recipients array might not always be the user
https://discord.com/channels/222078108977594368/824411059443204127/1054159754815098951

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Dec 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated
discord-js ⬜️ Ignored (Inspect) Dec 24, 2022 at 7:38AM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Dec 24, 2022 at 7:38AM (UTC)

@kodiakhq kodiakhq bot merged commit 7ce9909 into discordjs:main Dec 24, 2022
@almeidx almeidx deleted the discord.js/dm-channel-recipient-id branch December 24, 2022 07:45
almeidx added a commit to almeidx/discord.js that referenced this pull request Jan 5, 2023
almeidx added a commit to almeidx/discord.js that referenced this pull request Jan 5, 2023
kodiakhq bot added a commit that referenced this pull request Jan 10, 2023
Revert "fix(DMChannel): recipientId edge case (#8950)"

This reverts commit 7ce9909.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants