Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Swap message reaction and emoji identifier types #8969

Merged
merged 4 commits into from Dec 31, 2022

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Resolves #8968 by somewhat swapping the types for EmojiIdentifierResolvable and MessageReactionResolvable.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Dec 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 31, 2022 at 0:34AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
discord-js-guide ⬜️ Ignored (Inspect) Dec 31, 2022 at 0:34AM (UTC)

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
Co-authored-by: Aura Román <kyradiscord@gmail.com>
@kodiakhq kodiakhq bot merged commit ad49845 into discordjs:main Dec 31, 2022
@Jiralite Jiralite deleted the types/message-reaction-types branch December 31, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Typing error for reactions
5 participants