refactor(Guild): Destructure object in guild editing #8971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
Jiralite
force-pushed
the
refactor/guild-edit-nicer
branch
from
7ed0225
to
c5d28fb
Compare
SpaceEEC
approved these changes
Dec 25, 2022
kyranet
requested changes
Dec 25, 2022
kyranet
approved these changes
Dec 25, 2022
vladfrangu
approved these changes
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This style of code isn't consistent with other parts of the library. I think destructuring the object here looks pretty neat and seems to result in code that's easier to look at. Personally, every time I've come across this, I think about doing this but end up not bothering. But now's the time, apparently!
I also reordered the parameters as they are in Discord's documentation.
There was also a pretty suspicious max-len rule modification here which I removed. It must have served an ideal purpose in the past, but presently, it doesn't seem to do much at all.
Status and versioning classification: