refactor(GuildManager): Better handling of creation code #8974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
I am sure that this approach is better than setting snake case names and deleting the camel case properties. It's also the approach of other areas of the library and helps tackle #5267.
I noticed
icon
is nullable here, but Discord's documentation doesn't seem to accept anull
value.I also reordered the parameters as they are in Discord's documentation.
Status and versioning classification: