typings(Attachment): make attachment private

[net-tech]

Please describe the changes this PR makes and why it should be merged:

Removes <Attachment>.attachment. This isn't documented anywhere in the docs and from my testing returns a URL like https://cdn.discordapp.com/ephemeral-attachments/XXXXXXXXXXXXXXXXXX/XXXXXXXXXXXXXXXXXX/message.txt. If this is here on purpose then the typing should be string, not BufferResolvable | Stream.

Status and versioning classification:

• This PR only includes non-code changes, like changes to documentation, README, etc.
• Code changes have been tested against the Discord API, or there are no code changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
discord-js	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 17, 2023 at 9:13PM (UTC)
discord-js-guide	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 17, 2023 at 9:13PM (UTC)

[Jiralite]

I cannot seem to find where this is referenced:

discord.js/packages/discord.js/src/structures/Attachment.js

Line 17 in 3160ab0

this.attachment = data.url;

Perhaps it's a remnant of an old refactor - possibly from being split into a builder? That property can be removed too. Pretty sure.

[Jiralite]

Okay, I just found out how and where this is being used.

Let's say a message is created and it has an attachment. They would be created as an Attachment. The property this.attachment = data.url; is being defined here.

We modify that via AttachmentBuilder.from(). For example: const attachment = AttachmentBuilder.from(message.attachments.first());

Without that property, it looks like the AttachmentBuilder will not be properly created. Definitely something funny is going on here (I'm a little confused by the JSDoc), but for now, I would keep that property as it is and remove only the typing or make it private.

[net-tech]

@Jiralite Wait, revert structures change and keep the typing removed entirely or revert structures change and keep the typing but change it to string?

[Jiralite]

Probably best to remove the typings altogether since there is no documentation for it.

[Syjalo]

Isn't it better to make that property private?

[net-tech]

Isn't it better to make that property private?

Done.

[Idris1401]

Maybe you should change the return type too, if it actually returns a string (or it doesn't matter?).

[Jiralite]

Do you mind also modifying the pull request title to reflect the changes too?