Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Allow builders to set channel types in discord.js #8990

Merged
merged 2 commits into from Jan 2, 2023

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
It wasn't possible to use a SlashCommandChannelOption in conjunction with discord.js's ApplicationCommandChannelOption as the types were different.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Dec 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 2, 2023 at 3:23PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
discord-js-guide ⬜️ Ignored (Inspect) Jan 2, 2023 at 3:23PM (UTC)

@kodiakhq kodiakhq bot merged commit 7dec892 into discordjs:main Jan 2, 2023
@Jiralite Jiralite deleted the types/channel-type-from-builder branch January 2, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants