Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(websocketshard): backport zombie connection fix #9003

Merged
merged 2 commits into from Jan 2, 2023
Merged

fix(websocketshard): backport zombie connection fix #9003

merged 2 commits into from Jan 2, 2023

Conversation

legendhimself
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
backport: #8989
Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Jan 1, 2023

@legendhimself is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jan 1, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ❌ Failed (Inspect) Jan 1, 2023 at 9:27PM (UTC)

@legendhimself
Copy link
Contributor Author

not sure If the package-lock.json was meant to be updated.

@Jiralite Jiralite added this to the discord.js v13.13 milestone Jan 1, 2023
@Qjuh
Copy link
Contributor

Qjuh commented Jan 1, 2023

Gonna review this tomorrow.

Qjuh
Qjuh approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@Qjuh Qjuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, seems to match v14 in functionality.

@iCrawl iCrawl merged commit 56e6718 into discordjs:v13 Jan 2, 2023
@legendhimself legendhimself deleted the backport/wsFix branch January 2, 2023 14:59
@JMTK JMTK mentioned this pull request Nov 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@DraftProducts DraftProducts DraftProducts approved these changes

@Qjuh Qjuh Qjuh approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
backport gateway packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js 13.13.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@legendhimself @Qjuh @kyranet @SpaceEEC @DraftProducts @iCrawl @Jiralite