feat(Collector): add lastCollectedTimestamp #9044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you should change the name @ImRodry |
ImRodry
changed the title
|
lol didn't notice it |
ImRodry
force-pushed
the
feat/collector-add-lastCollectedTimestamp
branch
from
57ce859
to
4309d4d
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The formatting errors are due to an update to prettier that changed a rule. Should I commit those changes? |
Syjalo
suggested changes
Jan 11, 2023
ImRodry
force-pushed
the
feat/collector-add-lastCollectedTimestamp
branch
from
77f8c86
to
60ff227
Compare
kyranet
requested changes
Jan 13, 2023
Co-authored-by: Synbulat Biishev <syjalo.dev@gmail.com>
ImRodry
force-pushed
the
feat/collector-add-lastCollectedTimestamp
branch
from
2690fbf
to
1e0f6a6
Compare
ImRodry
requested review from
kyranet
and removed request for
vladfrangu,
iCrawl and
SpaceEEC
|
would love to know how in the world I removed those review requests lol |
ImRodry
force-pushed
the
feat/collector-add-lastCollectedTimestamp
branch
from
1e0f6a6
to
b0ca2c1
Compare
kyranet
approved these changes
Feb 17, 2023
|
Probably you can also add |
|
maybe a new pr |
SpaceEEC
approved these changes
Mar 12, 2023
vladfrangu
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds a new property and a new getter to the Collector class to store the timestamp at which the collector last collected an item. This is useful for determining when the collector will end when an idle timeout is specified as there is currently no reliable way to get this information from Node without using private properties of the Timeout class and weird hacks
Status and versioning classification: