fix(ThreadChannel): insert starter message from threads created in forum channels #9100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
vladfrangu
approved these changes
Feb 8, 2023
kyranet
approved these changes
Feb 8, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
iCrawl
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Threads created in forum channels return the message object within the payload1. discord.js ignored detecting if
messagewas indatahere leaving it to the laterMESSAGE_CREATEevent to populate, but we can do this straight away.One may ask if it could be possible for both the handler and the WebSocket to inject a duplicate message into the cache here. I have found that the gateway does not emit the message—only via REST it does.
Status and versioning classification:
Footnotes
https://discord.com/developers/docs/resources/channel#start-thread-in-forum-channel ↩