feat: align some methods with the Change By Copy proposal #9207
+51
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
almeidx
commented
Mar 6, 2023
almeidx
force-pushed
the
collection/change-by-copy
branch
from
bf7b646 to
71725f1
Compare
kyranet
previously requested changes
Mar 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #9207 +/- ##
==========================================
+ Coverage 60.39% 60.41% +0.01%
==========================================
Files 233 233
Lines 16161 16169 +8
Branches 1232 1233 +1
==========================================
+ Hits 9760 9768 +8
Misses 6357 6357
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
vladfrangu
approved these changes
May 1, 2023
almeidx
changed the title
almeidx
force-pushed
the
collection/change-by-copy
branch
from
1b0706c to
8005d6f
Compare
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-almeidx-collection-change-by-copy-discordjs.vercel.app/ |
suneettipirneni
approved these changes
Nov 7, 2023
SpaceEEC
approved these changes
Nov 7, 2023
BREAKING CHANGE: The `sorted` method has been renamed to `toSorted`
almeidx
force-pushed
the
collection/change-by-copy
branch
from
8005d6f to
a53403b
Compare
cobaltt7
added a commit
to scratchaddons-community/scradd
that referenced
this pull request
Dec 19, 2023
Signed-off-by: RedGuy12 <paul@reid-family.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Stage 4 proposal:
Overview of the changes:
sorted->toSortedtoReversedStatus and versioning classification: