Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GuildBasedTextChannelTypes #9234

Merged
merged 4 commits into from
Mar 22, 2023
Merged

feat: add GuildBasedTextChannelTypes #9234

merged 4 commits into from
Mar 22, 2023

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Mar 15, 2023

Please describe the changes this PR makes and why it should be merged:
Since 14.8.0, Constants.TextBasedChannelTypes is no longer assignable to ApplicationCommand#channelTypes due to the DM type not being accepted, so this fixes that
Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Mar 15, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 10:03PM (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 10:03PM (UTC)

@ImRodry
Copy link
Contributor Author

ImRodry commented Mar 15, 2023

Also as a sidenote I can't get CI to pass locally so I committed this with --no-verify

@ImRodry ImRodry force-pushed the feat/guildtextbasechanneltypes branch from 4529a10 to 8526d2e Compare March 15, 2023 03:40
@ImRodry
Copy link
Contributor Author

ImRodry commented Mar 15, 2023

Which of course explains the CI fail but it should pass now

@Jiralite Jiralite added this to the discord.js 14.9 milestone Mar 15, 2023
@Jiralite
Copy link
Member

This needs a rebase (stage channels were added here).

@ImRodry
Copy link
Contributor Author

ImRodry commented Mar 15, 2023

Thanks for the heads up! Rebased it now

@ImRodry ImRodry force-pushed the feat/guildtextbasechanneltypes branch from 8526d2e to cdcfc73 Compare March 15, 2023 18:31
@ImRodry
Copy link
Contributor Author

ImRodry commented Mar 15, 2023

Rebased twice cuz I forgot the docs

@ImRodry ImRodry force-pushed the feat/guildtextbasechanneltypes branch from cdcfc73 to 62e03f2 Compare March 15, 2023 18:32
@ImRodry @jaw0r3k
docs(GuildTextBasedChannels): distinguish from non other
e00029b 
Co-authored-by: Jaw0r3k <jaworekwiadomosci@gmail.com>
@vladfrangu
Copy link
Member

ApplicationCommand#channelTypes

Are you referring to the channel option types? 👁️

@Jiralite
Copy link
Member

To be crystal clear, it is caused by #8990 due to now-narrow typings.

@ImRodry
Copy link
Contributor Author

ImRodry commented Mar 17, 2023

That is indeed what I meant. I also recall proposing this change a while ago but it was rejected since Discord allows any channel types (which it still does to my knowledge) so I find it a bit odd that it was done now but yeah that was the motivation

@ImRodry @vladfrangu
fix: spread correct array
7ed10f2 
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
@ImRodry ImRodry requested review from vladfrangu and removed request for iCrawl and kyranet March 18, 2023 18:44
@ImRodry
Copy link
Contributor Author

ImRodry commented Mar 18, 2023

So the removing review bug is still a thing, nice. Can someone add those back?

vladfrangu
vladfrangu approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub you drunk drunk

@kodiakhq kodiakhq bot merged commit 5f93dcc into discordjs:main Mar 22, 2023
@ImRodry ImRodry deleted the feat/guildtextbasechanneltypes branch April 16, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaw0r3k jaw0r3k jaw0r3k left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

Assignees
No one assigned
Labels
packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js 14.9
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ImRodry @Jiralite @vladfrangu @kyranet @SpaceEEC @jaw0r3k