fix(ThreadManager): Respect `cache` and `force` in fetching #9239

Jiralite · 2023-03-16T17:53:31Z

Please describe the changes this PR makes and why it should be merged:
This method was internally not passing cache and force correctly:

discord.js/packages/discord.js/src/managers/ChannelManager.js

Lines 106 to 117 in 51edba7

    
             /** 
        
              * Obtains a channel from Discord, or the channel cache if it's already available. 
        
              * @param {Snowflake} id The channel's id 
        
              * @param {FetchChannelOptions} [options] Additional options for this fetch 
        
              * @returns {Promise<?BaseChannel>} 
        
              * @example 
        
              * // Fetch a channel by its id 
        
              * client.channels.fetch('222109930545610754') 
        
              *   .then(channel => console.log(channel.name)) 
        
              *   .catch(console.error); 
        
              */ 
        
             async fetch(id, { allowUnknownGuild = false, cache = true, force = false } = {}) {

Status and versioning classification:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating

vercel · 2023-03-16T17:53:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
discord-js	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 22, 2023 at 7:21PM (UTC)
discord-js-guide	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 22, 2023 at 7:21PM (UTC)

These are already defaulted down the line.

* fix(Message#editable): update editable check in threads locked (#9216) * fix(Message#editable): update editable check in threads locked * fix(Message#editable): add check in archived threads * fix: check manage threads permission only if thread is locked * fix: adding a full stop at the end of a sentence Co-authored-by: Jaworek <jaworekwiadomosci@gmail.com> --------- Co-authored-by: Jaworek <jaworekwiadomosci@gmail.com> Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com> * fix(ThreadManager): Respect `cache` and `force` in fetching (#9239) * fix(ThreadManager): Respect `cache` and `force` in fetching * refactor: remove defaults These are already defaulted down the line. --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(FetchThreadsOptions): Remove `active` (#9241) * refactor(FetchThreadsOptions): remove `active` * docs(FetchThreadsOptions): update description --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * docs: add more examples (#9252) * docs: add more examples * fix: fix grammar and syntax Co-authored-by: Jaw0r3k <jaworekwiadomosci@gmail.com> * chore: fine-tune examples * chore: replace double quotes with singles * fix: remove redundant example tag * fix: fix timeout logging * Update packages/discord.js/src/structures/GuildMember.js Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> --------- Co-authored-by: Jaw0r3k <jaworekwiadomosci@gmail.com> Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com> Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * docs(Role): Fix example for `comparePositionTo()` * docs(FetchArchivedThreadOptions): `before` respects `archive_timestamp`, not creation timestamp (#9240) docs(FetchArchivedThreadOptions): correct `before` description Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(snowflake): snowflakes length (#9144) * fix(snowflake): fix snowflakes length * fix(snowflake): fix length * fix(Message): `bulkDeletable` permissions should be retrieved later for DMs (#9146) * fix(Message): permissions check should be done later the getter will error if used on a message originating from a DM * refactor: remove unessercary chaining * fix: invalid backport Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com> * docs(Role): fix comparison example * fix(ClientUser): no mutation on edit * refactor: call bans.create directly * fix(AutocompleteInteraction): Send `name_localizations` correctly (#9238) fix(AutocompleteInteraction): send locale correctly Co-authored-by: space <spaceeec@yahoo.com> * fix: resolving string bitfield (#9262) fix: resolving bitfield Co-authored-by: space <spaceeec@yahoo.com> * fix: Keep symbols in actions manager (#9293) fix: keep symbols in actions manager * fix: add support for new guild feature `GUILD_WEB_PAGE_VANITY_URL` (#9219) Co-authored-by: space <spaceeec@yahoo.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * docs: differ `User#send` (#9251) * docs: differate user#send * chore: format * chore: remove some examples * docs: add GuildMember#send example --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * docs: describe private properties (#8879) * feat: describe private properties * Update packages/discord.js/src/structures/GuildMember.js Co-authored-by: MrMythicalYT <91077061+MrMythicalYT@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: MrMythicalYT <91077061+MrMythicalYT@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: MrMythicalYT <91077061+MrMythicalYT@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> --------- Co-authored-by: Erwan <erwan977@gmail.com> Co-authored-by: Jaworek <jaworekwiadomosci@gmail.com> Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Tetie <tjvssr@gmail.com> Co-authored-by: DraftMan <contact@draftman.fr> Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com> Co-authored-by: Jaw0r3k <jaw0r3k.g@gmail.com> Co-authored-by: space <spaceeec@yahoo.com> Co-authored-by: pkdev08 <54294685+pkdev08@users.noreply.github.com> Co-authored-by: MrMythicalYT <91077061+MrMythicalYT@users.noreply.github.com>

fix(ThreadManager): Respect cache and force in fetching

1a9fd85

github-actions bot added the packages:discord.js label Mar 16, 2023

github-actions bot requested review from iCrawl, kyranet, SpaceEEC and vladfrangu March 16, 2023 17:53

Jiralite added semver:patch threads labels Mar 16, 2023

Jiralite added this to the discord.js 14.9 milestone Mar 16, 2023

vercel bot deployed to Preview – discord-js March 16, 2023 17:55 View deployment

vercel bot deployed to Preview – discord-js-guide March 16, 2023 17:56 View deployment

jaw0r3k approved these changes Mar 16, 2023

View reviewed changes

vladfrangu approved these changes Mar 17, 2023

View reviewed changes

SpaceEEC approved these changes Mar 17, 2023

View reviewed changes

refactor: remove defaults

e837503

These are already defaulted down the line.

vercel bot deployed to Preview – discord-js March 17, 2023 21:07 View deployment

vercel bot deployed to Preview – discord-js-guide March 17, 2023 21:08 View deployment

kyranet approved these changes Mar 22, 2023

View reviewed changes

Merge branch 'main' into patch-1

427eda5

kodiakhq bot merged commit cc57563 into discordjs:main Mar 22, 2023

vercel bot deployed to Preview – discord-js-guide March 22, 2023 19:21 View deployment

vercel bot deployed to Preview – discord-js March 22, 2023 19:21 View deployment

Jiralite deleted the patch-1 branch March 22, 2023 21:34

Jiralite mentioned this pull request Mar 23, 2023

chore: Miscellaneous fixes #9271

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ThreadManager): Respect `cache` and `force` in fetching #9239

fix(ThreadManager): Respect `cache` and `force` in fetching #9239

Jiralite commented Mar 16, 2023

vercel bot commented Mar 16, 2023 •

edited

	/**
	* Obtains a channel from Discord, or the channel cache if it's already available.
	* @param {Snowflake} id The channel's id
	* @param {FetchChannelOptions} [options] Additional options for this fetch
	* @returns {Promise<?BaseChannel>}
	* @example
	* // Fetch a channel by its id
	* client.channels.fetch('222109930545610754')
	* .then(channel => console.log(channel.name))
	* .catch(console.error);
	*/
	async fetch(id, { allowUnknownGuild = false, cache = true, force = false } = {}) {

fix(ThreadManager): Respect cache and force in fetching #9239

fix(ThreadManager): Respect cache and force in fetching #9239

Conversation

Jiralite commented Mar 16, 2023

vercel bot commented Mar 16, 2023 • edited

fix(ThreadManager): Respect `cache` and `force` in fetching #9239

fix(ThreadManager): Respect `cache` and `force` in fetching #9239

vercel bot commented Mar 16, 2023 •

edited