Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new permission name #9274

Merged
merged 3 commits into from Apr 19, 2023

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Mar 24, 2023

Please describe the changes this PR makes and why it should be merged:

🤖 Generated by Copilot at 891417a

This pull request updates the error codes, messages, and permission checks related to managing guild emojis, to reflect the Discord API's renaming of the ManageEmojisAndStickers permission to ManageGuildExpressions. It affects the files ErrorCodes.js, Messages.js, GuildEmojiManager.js, and GuildEmoji.js.

Depends on:

Upstream:

🤖 Generated by Copilot at 891417a

ManageGuildExpressions
New permission for emojis
Autumn of stickers

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Mar 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2023 2:22pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2023 2:22pm

@github-actions
Copy link

github-actions bot commented Mar 24, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 76
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-git-fork-almeidx-discordjs-new-perm-04392a-discordjs.vercel.app/

@httpEduardo

This comment was marked as off-topic.

@almeidx almeidx force-pushed the discord.js/new-permission-name branch from 891417a to 11cd4ca Compare April 19, 2023 00:19
@almeidx almeidx marked this pull request as ready for review April 19, 2023 00:20
@almeidx almeidx requested a review from a team as a code owner April 19, 2023 00:20
@Jiralite Jiralite removed the blocked label Apr 19, 2023
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a note telling users what to use instead (in your deprecation messages)?

@kodiakhq kodiakhq bot merged commit d2d27ce into discordjs:main Apr 19, 2023
6 checks passed
@almeidx almeidx deleted the discord.js/new-permission-name branch April 19, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants