docs: cleanup MessageCreateOptions and MessageReplyOptions #9283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BoogeyMan24 is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-boogeyman24-main-discordjs.vercel.app/ |
|
But it already has pr? |
|
I deleted stickers because MessageCreateOptions already has stickers. |
Jiralite
requested changes
Mar 27, 2023
|
I will just extend |
BoogeyMan24
requested review from
Jiralite
and removed request for
vladfrangu,
iCrawl,
kyranet and
SpaceEEC
|
For purposes of deduplication, I would:
|
|
I added the changes for deduplication as you suggested. |
jaw0r3k
reviewed
Apr 10, 2023
packages/discord.js/src/structures/interfaces/TextBasedChannel.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Jaw0r3k <jaworekwiadomosci@gmail.com>
Jiralite
approved these changes
Apr 12, 2023
Closed
vladfrangu
approved these changes
Apr 13, 2023
kyranet
approved these changes
Apr 13, 2023
vladfrangu
changed the title
vladfrangu
changed the title
vladfrangu
changed the title
iCrawl
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Changed
BaseMessageCreateOptionstoBaseMessageOptionsand addedtts,nonce,stickers, andflagsas well. All near line 822 indiscordjs/src/structures/Messages.js.Hopefully this fixes #9209.
Edit: As suggested by Jiralite and for deduplication purposes,
BaseMessageCreateOptionshas been created to contain the the shared data ofMessageCreateOptionsandMessageReplyOptions.MessageCreateOptionsandMessageReplyOptionshave been updated to extendBaseMessageCreateOptionsand have their respective special properties addedreply, andfailIfNotExists.I probably may have missed something, so if I did just send a comment and I will change it.
Status and versioning classification:
There are no code changes
This PR only includes non-code changes, like changes to documentation, README, etc.