types(CategoryChannel): Ensure parent and parentId are null
#9327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Jiralite is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
Jiralite
changed the title
nullparent and parentId are null
jaw0r3k
reviewed
Apr 4, 2023
SpaceEEC
approved these changes
Apr 4, 2023
vladfrangu
approved these changes
Apr 13, 2023
kyranet
approved these changes
Apr 13, 2023
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-guide-git-fork-jiralite-types-ensur-1b7dc9-discordjs.vercel.app/ |
jaw0r3k
added a commit
to jaw0r3k/discord.js
that referenced
this pull request
Apr 23, 2023
…#9327) Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 967f113
Summary
📝🛠️🚫
Add
parentIdandparentproperties toCategoryChannelclass and clarify warning message. This improves the consistency and documentation of the channel classes.Walkthrough
parentIdandparentproperties toCategoryChannelclass and update warning message insetParentmethod (link)