Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove fromInteraction in internal channel creation #9335

Merged
merged 3 commits into from Apr 14, 2023

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Apr 7, 2023

Please describe the changes this PR makes and why it should be merged:
This existence of this parsing became redundant due to discord/discord-api-docs#3486 (comment), and as such, the remnant code will be removed.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Apr 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 8:44pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 8:44pm

@vercel
Copy link

vercel bot commented Apr 7, 2023

@Jiralite is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 🧹

@github-actions
Copy link

github-actions bot commented Apr 14, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-git-fork-jiralite-refactor-from-int-9209a8-discordjs.vercel.app/

@kodiakhq kodiakhq bot merged commit 794abe8 into discordjs:main Apr 14, 2023
6 checks passed
@Jiralite Jiralite deleted the refactor/from-interaction-removal branch April 14, 2023 21:53
jaw0r3k added a commit to jaw0r3k/discord.js that referenced this pull request Apr 23, 2023
…djs#9335)

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants