Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BaseInteraction): Support new channel payload #9337

Merged
merged 5 commits into from Apr 16, 2023

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Apr 7, 2023

Please describe the changes this PR makes and why it should be merged:

Note
Due to the changelog entry stating channel_id may be deprecated in the future, channel.id is preferred.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Apr 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2023 2:31pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2023 2:31pm

@vercel
Copy link

vercel bot commented Apr 7, 2023

@Jiralite is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@jaw0r3k
Copy link
Contributor

jaw0r3k commented Apr 7, 2023

.channel can now also be APIChannel, so isnt it a braking change?
if not, you should add it to the docs and typings
also add private prop _channel to typings

Co-Authored-By: Synbulat Biishev <contact@syjalo.dev>
@github-actions
Copy link

github-actions bot commented Apr 14, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-git-fork-jiralite-feat-interaction-channel-discordjs.vercel.app/

@kodiakhq kodiakhq bot merged commit 29389e3 into discordjs:main Apr 16, 2023
5 of 6 checks passed
@Jiralite Jiralite deleted the feat/interaction-channel branch April 16, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants