perf(RoleManager): dont call Role#position getter twice per role

[almeidx]

Please describe the changes this PR makes and why it should be merged:
Stored the position of the roles to not call the position getter twice per role as it is a reasonably heavy operation

Role#position

discord.js/packages/discord.js/src/structures/Role.js

Lines 186 to 189 in b2eec5f

	get position() {
	const sorted = this.guild._sortedRoles();
	return [...sorted.values()].indexOf(sorted.get(this.id));
	}

discord.js/packages/discord.js/src/structures/Guild.js

Lines 1296 to 1298 in b2eec5f

	_sortedRoles() {
	return discordSort(this.roles.cache);
	}

discord.js/packages/discord.js/src/util/Util.js

Lines 270 to 277 in b2eec5f

	function discordSort(collection) {
	const isGuildChannel = collection.first() instanceof GuildChannel;
	return collection.sorted(
	isGuildChannel
	? (a, b) => a.rawPosition - b.rawPosition || Number(BigInt(a.id) - BigInt(b.id))
	: (a, b) => a.rawPosition - b.rawPosition || Number(BigInt(b.id) - BigInt(a.id)),
	);
	}

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
discord-js-guide	⬜️ Ignored (Inspect)			Apr 9, 2023 10:26am

[vercel]

@almeidx is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.