Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Attachment): voice messages #9392

Merged
merged 2 commits into from Apr 21, 2023

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Apr 14, 2023

Please describe the changes this PR makes and why it should be merged:
Upstream:

馃 Generated by Copilot at e499142

Summary

馃幍馃搳馃晵

Add support for audio attachments by introducing duration and waveform properties to the Attachment class. Use nullish coalescing to handle optional data.

Attachment grows
Two new fields for audio
Winter silence ?? null

Walkthrough

  • Add duration and waveform properties to Attachment class (link, )

Status and versioning classification:

@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js 猬滐笍 Ignored (Inspect) Apr 19, 2023 5:35pm
discord-js-guide 猬滐笍 Ignored (Inspect) Apr 19, 2023 5:35pm

Copy link
Contributor

@TetieWasTaken TetieWasTaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantic change

packages/discord.js/src/structures/Attachment.js Outdated Show resolved Hide resolved
packages/discord.js/src/structures/Attachment.js Outdated Show resolved Hide resolved
@Jiralite Jiralite added this to the discord.js 14.11 milestone Apr 16, 2023
@Jiralite Jiralite removed the blocked label Apr 19, 2023
Co-authored-by: Tetie <tjvssr@gmail.com>
@almeidx almeidx requested a review from a team as a code owner April 19, 2023 17:35
@iCrawl iCrawl merged commit 3e01f91 into discordjs:main Apr 21, 2023
6 checks passed
@almeidx almeidx deleted the discord.js/voice-messages branch April 21, 2023 12:49
didinele pushed a commit that referenced this pull request Apr 21, 2023
Co-authored-by: Tetie <tjvssr@gmail.com>
@Jiralite Jiralite mentioned this pull request Apr 23, 2023
Jiralite added a commit to discordjs/guide that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants