Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(BaseMessageOptions): Fix embeds and components #9437

Merged
merged 2 commits into from Apr 21, 2023

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
For embeds, an array of EmbedBuilders were missing.
For action rows, an array of APIActionRowComponents were missing (this is typed already).

Also, they're now all within the same array as we simply call the JSON transformer or rebuild from the passed data, so it's technically accurate now.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Apr 21, 2023 8:40pm
discord-js-guide ⬜️ Ignored (Inspect) Apr 21, 2023 8:40pm

@kodiakhq kodiakhq bot merged commit 5c52bb9 into main Apr 21, 2023
7 checks passed
@kodiakhq kodiakhq bot deleted the docs/base-message-options-fixes branch April 21, 2023 20:43
jaw0r3k added a commit to jaw0r3k/discord.js that referenced this pull request Apr 23, 2023
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
iCrawl pushed a commit that referenced this pull request May 1, 2023
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Almeida <almeidx@pm.me>
Co-authored-by: kyranet <kyradiscord@gmail.com>
Fix embeds and components (#9437)
fix links and invalid syntax (#9322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants