Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(AutoModerationActionMetadataOptions): make channel property optional #9460

Merged
merged 4 commits into from Apr 28, 2023

Conversation

Idris1401
Copy link
Contributor

@Idris1401 Idris1401 commented Apr 26, 2023

Please describe the changes this PR makes and why it should be merged:

Fixes #9459

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Idris1401 Idris1401 requested a review from a team as a code owner April 26, 2023 21:33
@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 5:18pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 5:18pm

@github-actions
Copy link

github-actions bot commented Apr 28, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 90
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-git-fork-idris1401-types-fix-channel-prop-discordjs.vercel.app/

@kodiakhq kodiakhq bot merged commit d26df5f into discordjs:main Apr 28, 2023
5 of 6 checks passed
@Idris1401 Idris1401 deleted the types/fix-channel-prop branch April 28, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Required channel in automoderationRule.create
5 participants