Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(StringSelectMenuComponentData): options is required #9515

Merged
merged 2 commits into from May 5, 2023

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented May 4, 2023

Please describe the changes this PR makes and why it should be merged:
The options of a string select menu are required. Sending a request without options will yield an error:

DiscordAPIError[50035]: Invalid Form Body
components[0].components[0].options[BASE_TYPE_BAD_LENGTH]: Must be between 1 and 25 in length.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 0:26am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) May 5, 2023 0:26am

@github-actions
Copy link

github-actions bot commented May 5, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 79
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 94
🟠 PWA 70

Lighthouse ran on https://discord-js-guide-git-fix-options-required-discordjs.vercel.app/guide/home/introduction

@kodiakhq kodiakhq bot merged commit d7b18f0 into main May 5, 2023
7 checks passed
@kodiakhq kodiakhq bot deleted the fix/options-required branch May 5, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants