From 7f572bc22801d17d49cdd8708fa2afdaa8ce12ef Mon Sep 17 00:00:00 2001 From: TheMaestro0 Date: Wed, 2 Jun 2021 06:46:32 +0200 Subject: [PATCH 1/4] fix(RoleManager): bug in #create --- src/managers/RoleManager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/managers/RoleManager.js b/src/managers/RoleManager.js index 04aa47d000c6..c5d42c713047 100644 --- a/src/managers/RoleManager.js +++ b/src/managers/RoleManager.js @@ -115,7 +115,7 @@ class RoleManager extends BaseManager { create(options = {}) { let { name, color, hoist, permissions, position, mentionable, reason } = options; if (color) color = resolveColor(color); - if (permissions) permissions = Permissions.resolve(permissions).toString(); + if (typeof permissions !== 'undefined') permissions = Permissions.resolve(permissions).toString(); return this.client.api .guilds(this.guild.id) From 632abec34e488bca1a5a667ee606fb488f0e06b3 Mon Sep 17 00:00:00 2001 From: TheMaestroo <61483023+TheMaestro0@users.noreply.github.com> Date: Wed, 2 Jun 2021 07:49:05 +0200 Subject: [PATCH 2/4] apply suggestion Co-authored-by: ckohen --- src/managers/RoleManager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/managers/RoleManager.js b/src/managers/RoleManager.js index c5d42c713047..ef982af7b6dd 100644 --- a/src/managers/RoleManager.js +++ b/src/managers/RoleManager.js @@ -115,7 +115,7 @@ class RoleManager extends BaseManager { create(options = {}) { let { name, color, hoist, permissions, position, mentionable, reason } = options; if (color) color = resolveColor(color); - if (typeof permissions !== 'undefined') permissions = Permissions.resolve(permissions).toString(); + permissions = Permissions.resolve(permissions).toString(); return this.client.api .guilds(this.guild.id) From 6431b796271906bbdf36d08287ddd7c3dd68fdeb Mon Sep 17 00:00:00 2001 From: TheMaestro0 Date: Wed, 2 Jun 2021 10:14:04 +0200 Subject: [PATCH 3/4] Here we go! --- src/managers/RoleManager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/managers/RoleManager.js b/src/managers/RoleManager.js index ef982af7b6dd..d7e11b48727e 100644 --- a/src/managers/RoleManager.js +++ b/src/managers/RoleManager.js @@ -115,7 +115,7 @@ class RoleManager extends BaseManager { create(options = {}) { let { name, color, hoist, permissions, position, mentionable, reason } = options; if (color) color = resolveColor(color); - permissions = Permissions.resolve(permissions).toString(); + permissions = new Permissions(permissions); return this.client.api .guilds(this.guild.id) From 1be5dd9e1a28ae6503d27a8244016403a03eb6a2 Mon Sep 17 00:00:00 2001 From: TheMaestro0 Date: Wed, 2 Jun 2021 16:33:46 +0200 Subject: [PATCH 4/4] last one, I hope! --- src/managers/RoleManager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/managers/RoleManager.js b/src/managers/RoleManager.js index d7e11b48727e..ea76380c151a 100644 --- a/src/managers/RoleManager.js +++ b/src/managers/RoleManager.js @@ -115,7 +115,7 @@ class RoleManager extends BaseManager { create(options = {}) { let { name, color, hoist, permissions, position, mentionable, reason } = options; if (color) color = resolveColor(color); - permissions = new Permissions(permissions); + if (typeof permissions !== 'undefined') permissions = new Permissions(permissions); return this.client.api .guilds(this.guild.id)