From 075a77e77aa9e5c6d8d04199242b01b567308845 Mon Sep 17 00:00:00 2001 From: Shubham Parihar Date: Fri, 17 Sep 2021 11:41:17 +0530 Subject: [PATCH 1/4] feat(MessageAttachment): add support for ephemeral property --- src/structures/MessageAttachment.js | 6 ++++++ typings/index.d.ts | 1 + 2 files changed, 7 insertions(+) diff --git a/src/structures/MessageAttachment.js b/src/structures/MessageAttachment.js index 5c046bfb6e18..6db5957c4c5a 100644 --- a/src/structures/MessageAttachment.js +++ b/src/structures/MessageAttachment.js @@ -103,6 +103,12 @@ class MessageAttachment { * @type {?string} */ this.contentType = data.content_type ?? null; + + /** + * Whether this attachment is ephemeral + * @type {?boolean} + */ + this.ephemeral = data.ephemeral ?? null; } /** diff --git a/typings/index.d.ts b/typings/index.d.ts index 508991550e48..b3ed1567e0a1 100644 --- a/typings/index.d.ts +++ b/typings/index.d.ts @@ -1267,6 +1267,7 @@ export class MessageAttachment { public attachment: BufferResolvable | Stream; public contentType: string | null; + public ephemeral: boolean | null; public height: number | null; public id: Snowflake; public name: string | null; From c93048c14650e64d812fe7059a11ac3d9416d1f2 Mon Sep 17 00:00:00 2001 From: Shubham Parihar Date: Mon, 27 Sep 2021 06:34:38 +0530 Subject: [PATCH 2/4] feat(MessageAttachment): default ephemeral to false when not present Co-authored-by: Rodry <38259440+ImRodry@users.noreply.github.com> --- src/structures/MessageAttachment.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/structures/MessageAttachment.js b/src/structures/MessageAttachment.js index 6db5957c4c5a..aa9b547b147b 100644 --- a/src/structures/MessageAttachment.js +++ b/src/structures/MessageAttachment.js @@ -108,7 +108,7 @@ class MessageAttachment { * Whether this attachment is ephemeral * @type {?boolean} */ - this.ephemeral = data.ephemeral ?? null; + this.ephemeral = data.ephemeral ?? false; } /** From 697c20e52d7c7a2d9faabed53ffd80f35f0e2acb Mon Sep 17 00:00:00 2001 From: Shubham Parihar Date: Mon, 27 Sep 2021 06:37:27 +0530 Subject: [PATCH 3/4] docs(MessageAttachment): update jsdoc for ephemeral field --- src/structures/MessageAttachment.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/structures/MessageAttachment.js b/src/structures/MessageAttachment.js index aa9b547b147b..513c136d98d5 100644 --- a/src/structures/MessageAttachment.js +++ b/src/structures/MessageAttachment.js @@ -106,7 +106,7 @@ class MessageAttachment { /** * Whether this attachment is ephemeral - * @type {?boolean} + * @type {boolean} */ this.ephemeral = data.ephemeral ?? false; } From d9a15067608fb81a5b2424fbe097af4aba8fd35e Mon Sep 17 00:00:00 2001 From: Shubham Parihar Date: Mon, 27 Sep 2021 06:39:24 +0530 Subject: [PATCH 4/4] types(MessageAttachment): update typings for ephemeral --- typings/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/typings/index.d.ts b/typings/index.d.ts index b3ed1567e0a1..75d46beb5dec 100644 --- a/typings/index.d.ts +++ b/typings/index.d.ts @@ -1267,7 +1267,7 @@ export class MessageAttachment { public attachment: BufferResolvable | Stream; public contentType: string | null; - public ephemeral: boolean | null; + public ephemeral: boolean; public height: number | null; public id: Snowflake; public name: string | null;