From 881d4cd2869e5e75d3d1b862937a9ae0401b17f6 Mon Sep 17 00:00:00 2001 From: Jiralite <33201955+Jiralite@users.noreply.github.com> Date: Wed, 22 Sep 2021 14:06:12 +0100 Subject: [PATCH 1/2] fix: use set correctly --- src/managers/GuildEmojiRoleManager.js | 2 +- src/managers/GuildMemberRoleManager.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/managers/GuildEmojiRoleManager.js b/src/managers/GuildEmojiRoleManager.js index 937485740331..2b8a830c1bf2 100644 --- a/src/managers/GuildEmojiRoleManager.js +++ b/src/managers/GuildEmojiRoleManager.js @@ -51,7 +51,7 @@ class GuildEmojiRoleManager extends DataManager { resolvedRoles.push(resolvedRole); } - const newRoles = [...new Set(resolvedRoles.concat(...this.cache.values()))]; + const newRoles = [...new Set(resolvedRoles.concat(...this.cache.map(role => role.id)))]; return this.set(newRoles); } diff --git a/src/managers/GuildMemberRoleManager.js b/src/managers/GuildMemberRoleManager.js index e4ae17397085..4a4570dafa18 100644 --- a/src/managers/GuildMemberRoleManager.js +++ b/src/managers/GuildMemberRoleManager.js @@ -102,7 +102,7 @@ class GuildMemberRoleManager extends DataManager { resolvedRoles.push(resolvedRole); } - const newRoles = [...new Set(resolvedRoles.concat(...this.cache.values()))]; + const newRoles = [...new Set(resolvedRoles.concat(...this.cache.map(role => role.id)))]; return this.set(newRoles, reason); } else { roleOrRoles = this.guild.roles.resolveId(roleOrRoles); From 255e48e1f024c15b143ab600b34858f9cebe1e5b Mon Sep 17 00:00:00 2001 From: Jiralite <33201955+Jiralite@users.noreply.github.com> Date: Wed, 22 Sep 2021 14:56:44 +0100 Subject: [PATCH 2/2] refactor: keys() Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com> --- src/managers/GuildEmojiRoleManager.js | 2 +- src/managers/GuildMemberRoleManager.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/managers/GuildEmojiRoleManager.js b/src/managers/GuildEmojiRoleManager.js index 2b8a830c1bf2..c44fb3ec5563 100644 --- a/src/managers/GuildEmojiRoleManager.js +++ b/src/managers/GuildEmojiRoleManager.js @@ -51,7 +51,7 @@ class GuildEmojiRoleManager extends DataManager { resolvedRoles.push(resolvedRole); } - const newRoles = [...new Set(resolvedRoles.concat(...this.cache.map(role => role.id)))]; + const newRoles = [...new Set(resolvedRoles.concat(...this.cache.keys()))]; return this.set(newRoles); } diff --git a/src/managers/GuildMemberRoleManager.js b/src/managers/GuildMemberRoleManager.js index 4a4570dafa18..f5dd801da82f 100644 --- a/src/managers/GuildMemberRoleManager.js +++ b/src/managers/GuildMemberRoleManager.js @@ -102,7 +102,7 @@ class GuildMemberRoleManager extends DataManager { resolvedRoles.push(resolvedRole); } - const newRoles = [...new Set(resolvedRoles.concat(...this.cache.map(role => role.id)))]; + const newRoles = [...new Set(resolvedRoles.concat(...this.cache.keys()))]; return this.set(newRoles, reason); } else { roleOrRoles = this.guild.roles.resolveId(roleOrRoles);