From 2c6a448255d44ed7f869ee7a5a67f8faa595bac5 Mon Sep 17 00:00:00 2001 From: suneettipirneni Date: Thu, 14 Oct 2021 18:37:25 -0400 Subject: [PATCH 1/3] types: `PartialGuildMember#user` is never null --- typings/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/typings/index.d.ts b/typings/index.d.ts index fb954f29314e..7ad7513e372d 100644 --- a/typings/index.d.ts +++ b/typings/index.d.ts @@ -4709,7 +4709,7 @@ export interface PartialDMChannel extends Partialize {} +export interface PartialGuildMember extends Partialize {} export interface PartialMessage extends Partialize {} From 2e0aae0e3c7253d966749c97c1a6533cc9b13a40 Mon Sep 17 00:00:00 2001 From: suneettipirneni Date: Thu, 14 Oct 2021 19:32:13 -0400 Subject: [PATCH 2/3] chore: use types instead of interfaces --- typings/index.d.ts | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/typings/index.d.ts b/typings/index.d.ts index 7ad7513e372d..a5d90c53cb79 100644 --- a/typings/index.d.ts +++ b/typings/index.d.ts @@ -4709,12 +4709,15 @@ export interface PartialDMChannel extends Partialize {} +export type PartialGuildMember = Partialize; -export interface PartialMessage - extends Partialize {} +export type PartialMessage = Partialize< + Message, + 'type' | 'system' | 'pinned' | 'tts', + 'content' | 'cleanContent' | 'author' +>; -export interface PartialMessageReaction extends Partialize {} +export type PartialMessageReaction = Partialize; export interface PartialOverwriteData { id: Snowflake | number; @@ -4729,7 +4732,7 @@ export interface PartialRoleData extends RoleData { export type PartialTypes = 'USER' | 'CHANNEL' | 'GUILD_MEMBER' | 'MESSAGE' | 'REACTION'; -export interface PartialUser extends Partialize {} +export type PartialUser = Partialize; export type PresenceStatusData = ClientPresenceStatus | 'invisible'; From 3906448157897e33d4b358c19b0fd04ce84291dd Mon Sep 17 00:00:00 2001 From: Suneet Tipirneni Date: Fri, 15 Oct 2021 12:30:45 -0400 Subject: [PATCH 3/3] Revert "chore: use types instead of interfaces" This reverts commit 2e0aae0e3c7253d966749c97c1a6533cc9b13a40. --- typings/index.d.ts | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/typings/index.d.ts b/typings/index.d.ts index a5d90c53cb79..7ad7513e372d 100644 --- a/typings/index.d.ts +++ b/typings/index.d.ts @@ -4709,15 +4709,12 @@ export interface PartialDMChannel extends Partialize; +export interface PartialGuildMember extends Partialize {} -export type PartialMessage = Partialize< - Message, - 'type' | 'system' | 'pinned' | 'tts', - 'content' | 'cleanContent' | 'author' ->; +export interface PartialMessage + extends Partialize {} -export type PartialMessageReaction = Partialize; +export interface PartialMessageReaction extends Partialize {} export interface PartialOverwriteData { id: Snowflake | number; @@ -4732,7 +4729,7 @@ export interface PartialRoleData extends RoleData { export type PartialTypes = 'USER' | 'CHANNEL' | 'GUILD_MEMBER' | 'MESSAGE' | 'REACTION'; -export type PartialUser = Partialize; +export interface PartialUser extends Partialize {} export type PresenceStatusData = ClientPresenceStatus | 'invisible';