From d57b72cf159da385c19007fa7fd50e764c504d15 Mon Sep 17 00:00:00 2001 From: almeidx Date: Mon, 18 Jul 2022 15:05:52 +0100 Subject: [PATCH 1/2] fix(ApplicationCommandManager): allow passing 0n to defaultMemberPermissions --- .../discord.js/src/managers/ApplicationCommandManager.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/discord.js/src/managers/ApplicationCommandManager.js b/packages/discord.js/src/managers/ApplicationCommandManager.js index 23bddabef3ab..a2cfae4cea64 100644 --- a/packages/discord.js/src/managers/ApplicationCommandManager.js +++ b/packages/discord.js/src/managers/ApplicationCommandManager.js @@ -242,9 +242,10 @@ class ApplicationCommandManager extends CachedManager { } if ('defaultMemberPermissions' in command) { - default_member_permissions = command.defaultMemberPermissions - ? new PermissionsBitField(command.defaultMemberPermissions).bitfield.toString() - : command.defaultMemberPermissions; + default_member_permissions = + command.defaultMemberPermissions !== null + ? new PermissionsBitField(command.defaultMemberPermissions).bitfield.toString() + : command.defaultMemberPermissions; } return { From 541c59f51f398affb51945d2af85ea68c6e47780 Mon Sep 17 00:00:00 2001 From: almeidx Date: Tue, 19 Jul 2022 15:22:11 +0100 Subject: [PATCH 2/2] fix(ApplicationCommand): equals() --- packages/discord.js/src/structures/ApplicationCommand.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/discord.js/src/structures/ApplicationCommand.js b/packages/discord.js/src/structures/ApplicationCommand.js index 8bca0b08ed37..afdddaca9586 100644 --- a/packages/discord.js/src/structures/ApplicationCommand.js +++ b/packages/discord.js/src/structures/ApplicationCommand.js @@ -365,9 +365,10 @@ class ApplicationCommand extends Base { } if ('defaultMemberPermissions' in command) { - defaultMemberPermissions = command.defaultMemberPermissions - ? new PermissionsBitField(command.defaultMemberPermissions).bitfield - : null; + defaultMemberPermissions = + command.defaultMemberPermissions !== null + ? new PermissionsBitField(command.defaultMemberPermissions).bitfield + : null; } // Check top level parameters