From 76af4e5b3c4e0668689633e1076a0ec85dd7e970 Mon Sep 17 00:00:00 2001 From: Synbulat Biishev Date: Sun, 21 Aug 2022 23:58:00 +0500 Subject: [PATCH 1/2] fix(GuildMemberManager): `add()` method throws an error --- packages/discord.js/src/managers/GuildMemberManager.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/discord.js/src/managers/GuildMemberManager.js b/packages/discord.js/src/managers/GuildMemberManager.js index 703acf586522..37bb678f4b73 100644 --- a/packages/discord.js/src/managers/GuildMemberManager.js +++ b/packages/discord.js/src/managers/GuildMemberManager.js @@ -1,6 +1,5 @@ 'use strict'; -const { Buffer } = require('node:buffer'); const { setTimeout, clearTimeout } = require('node:timers'); const { Collection } = require('@discordjs/collection'); const { makeURLSearchParams } = require('@discordjs/rest'); @@ -129,7 +128,11 @@ class GuildMemberManager extends CachedManager { } const data = await this.client.rest.put(Routes.guildMember(this.guild.id, userId), { body: resolvedOptions }); // Data is an empty buffer if the member is already part of the guild. - return data instanceof Buffer ? (options.fetchWhenExisting === false ? null : this.fetch(userId)) : this._add(data); + return data instanceof Uint8Array + ? options.fetchWhenExisting === false + ? null + : this.fetch(userId) + : this._add(data); } /** From a0cfd2f455c3ed0f3c297bcb60cc12d284910e4d Mon Sep 17 00:00:00 2001 From: Synbulat Biishev Date: Mon, 22 Aug 2022 00:03:32 +0500 Subject: [PATCH 2/2] chore: update comment --- packages/discord.js/src/managers/GuildMemberManager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/discord.js/src/managers/GuildMemberManager.js b/packages/discord.js/src/managers/GuildMemberManager.js index 37bb678f4b73..6a4739f14777 100644 --- a/packages/discord.js/src/managers/GuildMemberManager.js +++ b/packages/discord.js/src/managers/GuildMemberManager.js @@ -127,7 +127,7 @@ class GuildMemberManager extends CachedManager { resolvedOptions.roles = resolvedRoles; } const data = await this.client.rest.put(Routes.guildMember(this.guild.id, userId), { body: resolvedOptions }); - // Data is an empty buffer if the member is already part of the guild. + // Data is an empty Uint8Array if the member is already part of the guild. return data instanceof Uint8Array ? options.fetchWhenExisting === false ? null