Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use glob instead of fs #1547

Open
mallusrgreatv2 opened this issue Feb 14, 2024 · 1 comment · May be fixed by #1486
Open

Use glob instead of fs #1547

mallusrgreatv2 opened this issue Feb 14, 2024 · 1 comment · May be fixed by #1486
Labels
t: request Suggestion to add new or change existing content

Comments

@mallusrgreatv2
Copy link

mallusrgreatv2 commented Feb 14, 2024 •
edited

Is your feature request related to a problem? Please describe.

Most people have a problem understanding the structure of the folders when it comes to command handlers in the guide.

Describe the solution you'd like

Using glob will help with nested folders as well has non-nested folders, but making the guide just a little harder to understand.
https://www.npmjs.com/package/glob
Glob can also be promisified using node:util. Node supports top-level await as well.
@mallusrgreatv2 mallusrgreatv2 added the t: request Suggestion to add new or change existing content label Feb 14, 2024
@Qjuh
Copy link

Qjuh commented Feb 14, 2024

There‘s a PR for that already: #1486

@Jiralite Jiralite linked a pull request Feb 14, 2024 that will close this issue
Modifying example to search command subfolders #1486
Open
@Jiralite Jiralite changed the title [Feature Request] Use glob instead of fs Use glob instead of fs Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: request Suggestion to add new or change existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modifying example to search command subfolders JonathanRJoyner/guide
2 participants
@mallusrgreatv2 @Qjuh