Docker support config via env vars #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
…nfig-via-env-vars
…nfig-via-env-vars
…nfig-via-env-vars
previnder
requested changes
Jun 8, 2024
|
Everything works now, the only thing that could probably be added would be a way to auto-generate the environment variables based on the struct rather than manually defining them, example here. However, it could always be added in a future PR. |
|
We could indeed use reflection for that, but I'm going to merge this one right now. But yeah that could be a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
inject-configto return a yaml file with the config containing env varsgenerate-yaml.jsto generate a new file calledui-config.yamlwhich is not included in git.Purpose
This PR now adds support for using environment variables making it way easier to run discuit via docker.
Related Issues
Requests When Reviewing
I didn't know how the cmd in
main.goshould be so it is calledinject-configbut it's most definitely free to be changed to a better name, as the current one was just a test/general and the purpose has changed.