Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure http transport for s3 storage driver #4159

Open
tvdfly opened this issue Nov 18, 2023 · 0 comments · May be fixed by #4160
Open

Configure http transport for s3 storage driver #4159

tvdfly opened this issue Nov 18, 2023 · 0 comments · May be fixed by #4160

Comments

@tvdfly
Copy link

tvdfly commented Nov 18, 2023

I'm using the registry with the s3 storage backend. I want to configure the http transport that the s3 storage driver uses to disable idle connection, disable keep alive, and add tracing spans for http requests.

Opening this issue to discuss potential solutions. I'll make a pr shortly with one possible solution.
tvdfly added a commit to tvdfly/distribution that referenced this issue Nov 18, 2023
@tvdfly
Add new http transport params to s3 storage driver
34ec45d 
This enables s3 storage driver users to disable keep alives `"disablekeepalives"`, disable idle connections `"disableidleconnections"`, and enable tracing for http requests `"enablehttpotel"`.

Fixes distribution#4159

Signed-off-by: T Van Doren <108194999+tvdfly@users.noreply.github.com>
@tvdfly tvdfly linked a pull request Nov 18, 2023 that will close this issue
Open
tvdfly added a commit to tvdfly/distribution that referenced this issue Nov 29, 2023
@tvdfly
Add new http transport params to azure, gcs, s3 storage drivers
e5df937 
This enables the azure, gcs, and s3 storage driver users to disable keep alives `"disablekeepalives"`, disable idle connections `"disableidleconnections"`, and enable tracing for http requests `"enableotelhttp"`.

Fixes distribution#4159

Signed-off-by: T Van Doren <108194999+tvdfly@users.noreply.github.com>
tvdfly added a commit to tvdfly/distribution that referenced this issue Dec 14, 2023
@tvdfly
Add new http transport params to azure, gcs, s3 storage drivers
b31c8d5 
This enables the azure, gcs, and s3 storage driver users to disable keep alives `"disablekeepalives"`, disable idle connections `"disableidleconnections"`, and enable tracing for http requests `"enableotelhttp"`.

Fixes distribution#4159

Signed-off-by: T Van Doren <108194999+tvdfly@users.noreply.github.com>
tvdfly added a commit to tvdfly/distribution that referenced this issue Dec 19, 2023
@tvdfly
Add new http transport params to azure, gcs, s3 storage drivers
d58e3ff 
This enables the azure, gcs, and s3 storage driver users to disable keep alives `"disablekeepalives"`.

Fixes distribution#4159

Signed-off-by: T Van Doren <108194999+tvdfly@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new http transport params to storage drivers tvdfly/distribution
1 participant
@tvdfly