[release/2.7 backport] Add reference.ParseDockerRef utility function #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @dmcgowan PTAL |
ParseDockerRef normalizes the image reference following the docker
convention. This is added mainly for backward compatibility. The reference
returned can only be either tagged or digested. For reference contains both tag
and digest, the function returns digested reference, e.g.
docker.io/library/busybox:latest@sha256:7cc4b5aefd1d0cadf8d97d4350462ba51c694ebca145b08d7d41b41acc8db5aa
will be returned as
docker.io/library/busybox@sha256:7cc4b5aefd1d0cadf8d97d4350462ba51c694ebca145b08d7d41b41acc8db5aa.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 0ac367f)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
2.7_backport_add_normalize_util
branch
from
ad4fa05
to
fad36ed
Compare
|
rebased to make the vendor-check pass (which should be fixed by #3001) |
Codecov Report
@@ Coverage Diff @@
## release/2.7 #3002 +/- ##
===============================================
+ Coverage 60.25% 60.38% +0.13%
===============================================
Files 103 103
Lines 8024 8038 +14
===============================================
+ Hits 4835 4854 +19
+ Misses 2546 2537 -9
- Partials 643 647 +4
Continue to review full report at Codecov.
|
|
ping @dmcgowan @manishtomar @stevvooe PTAL |
16 tasks
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2786 for the release/2.7 branch
to address containerd/containerd#3031 if included in a 2.7.x patch release
ParseDockerRef normalizes the image reference following the docker
convention. This is added mainly for backward compatibility. The reference
returned can only be either tagged or digested. For reference contains both tag
and digest, the function returns digested reference, e.g.
will be returned as