Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/2.7 backport] Bugfix: Make ipfilteredby not required #3088

Conversation

thaJeztah
Copy link
Member

backport of #2837 for the 2.7 release branch
relates to #2838

the documentation changes were cherry-picked as part of #3073

Signed-off-by: Vishesh Jindal <vishesh92@gmail.com>
(cherry picked from commit f9a0506)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@manishtomar @dmcgowan PTAL

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #3088 into release/2.7 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/2.7    #3088   +/-   ##
============================================
  Coverage        60.25%   60.25%           
============================================
  Files              103      103           
  Lines             8024     8024           
============================================
  Hits              4835     4835           
  Misses            2546     2546           
  Partials           643      643
Flag Coverage Δ
#linux 60.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd1309...afa9146. Read the comment docs.

@thaJeztah
Copy link
Member Author

@manishtomar @dmcgowan PTAL

Copy link
Contributor

@manishtomar manishtomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit bdf503a into distribution:release/2.7 Feb 23, 2020
@thaJeztah thaJeztah deleted the 2.7_backport_fix_cloudfront_middleware branch February 23, 2020 08:24
@thaJeztah
Copy link
Member Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants