New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.8] Release workflow #3565
[2.8] Release workflow #3565
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## release/2.8 #3565 +/- ##
============================================
Coverage 58.72% 58.72%
============================================
Files 102 102
Lines 7104 7104
============================================
Hits 4172 4172
Misses 2286 2286
Partials 646 646 Continue to review full report at Codecov.
|
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
flavor: | | ||
latest=false | ||
labels: | | ||
org.opencontainers.image.title=Distribution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be lowercase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took it from README: https://github.com/distribution/distribution#distribution
Other references also have capitalization: ...goals of the Distribution project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've no strong opinions -- just wondering out loud. PR looks great! I think it's fine to leave it like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinions either; Is this label actively used anywhere that we know of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont believe it is -- I think it's just @crazy-max adding it from the goodness of his heart for the people who might be interested in using it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have the license, revision, etc... as labels when the image is being built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also by default org.opencontainers.image.title
and org.opencontainers.image.description
will use the one from the GitHub API if we remove these override. In our case would result with:
org.opencontainers.image.title
: "distribution" (repo name)org.opencontainers.image.description
: "The toolkit to pack, ship, store, and deliver container content" (repo description)
So we can remove them in the workflow if the default ones suit to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kewl. There is no harm keeping them in. Thanks @crazy-max
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
follow-up #3552
degraded backport of #3315 to be able to trigger a release on
release/2.8
branch without artifacts releasing.cc @milosgajdos @thaJeztah
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com