From f8b7fd46bda24e80c188469fb5920940a853819b Mon Sep 17 00:00:00 2001 From: Sander Verweij Date: Tue, 11 Jul 2023 20:31:30 +0200 Subject: [PATCH] Remove warning on missing baseUrl, which tsconfig-paths ^4.0.0 doesn't require anymore (#105) * Remove warning on missing baseUrl, which tsconfig-paths ^4.0.0 doesn't require anymore * adds reference to PR to the changelog --- CHANGELOG.md | 2 ++ src/plugin.ts | 10 ---------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 06de927..198f903 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,8 @@ project adheres to [Semantic Versioning](http://semver.org/). ## [Unreleased](https://github.com/dividab/tsconfig-paths-webpack-plugin/compare/v4.0.1...master) +- Remove warning on missing baseUrl, which tsconfig-paths ^4.0.0 doesn't require anymore [#105](https://github.com/dividab/tsconfig-paths-webpack-plugin/pull/105). + ## [4.0.1](https://github.com/dividab/tsconfig-paths-webpack-plugin/compare/v4.0.0...v4.0.1) - 2023-03-09 - Update tsconfig-paths [#103](https://github.com/dividab/tsconfig-paths-webpack-plugin/pull/103). Thanks to [@rippedspine](https://github.com/rippedspine) for this PR! diff --git a/src/plugin.ts b/src/plugin.ts index 504afad..1016907 100644 --- a/src/plugin.ts +++ b/src/plugin.ts @@ -173,16 +173,6 @@ export class TsconfigPathsPlugin implements ResolvePluginInstance { return; } - const { baseUrl } = this; - - if (!baseUrl) { - // Nothing to do if there is no baseUrl - this.log.logWarning( - "tsconfig-paths-webpack-plugin: Found no baseUrl in tsconfig.json, not applying tsconfig-paths-webpack-plugin" - ); - return; - } - // The file system only exists when the plugin is in the resolve context. This means it's also properly placed in the resolve.plugins array. // If not, we should warn the user that this plugin should be placed in resolve.plugins and not the plugins array of the root config for example. // This should hopefully prevent issues like: https://github.com/dividab/tsconfig-paths-webpack-plugin/issues/9