Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on missing baseUrl in 4.0.0 even though it can be undefined #99

Closed
tooga opened this issue Aug 22, 2022 · 4 comments · Fixed by #105
Closed

Warning on missing baseUrl in 4.0.0 even though it can be undefined #99

tooga opened this issue Aug 22, 2022 · 4 comments · Fixed by #105

Comments

@tooga
Copy link

tooga commented Aug 22, 2022

Hi,

The 4.0.0 version has updated the tsconfig-paths dependency also to 4.0.0.

In tsconfig-paths 4.0.0 the baseUrl in tsconfig can also be undefined (dividab/tsconfig-paths#208). Still, this plugin returns "Found no baseUrl in tsconfig.json, not applying tsconfig-paths-webpack-plugin" as a result of missing baseUrl.

@jonaskello
Copy link
Member

Yes this check should be removed now then. I think we could consider it a bug that it is still there so it could be released quickly in a patch version.

@tooga Would you care to submit a PR to fix it?

@alfaproject
Copy link

Just stumbled upon this ):

@sverweij
Copy link
Contributor

Hi @jonaskello I've made a small PR (#105) to fix this issue as well as issue #59 - but not sure to have followed the right protocol for this project. Is there something I can/ need to do to further the resolution?

@jonaskello
Copy link
Member

Released in 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants