fix: allow absolute baseUrl in tsconfig.json #174
Conversation
src/config-loader.ts
Outdated
| const absoluteBaseUrl = path.join(tsConfigDir, loadResult.baseUrl); | ||
| const absoluteBaseUrl = path.isAbsolute(loadResult.baseUrl) | ||
| ? loadResult.baseUrl | ||
| : path.join(tsConfigDir, loadResult.baseUrl); |
There was a problem hiding this comment.
Use this instead please:
const absoluteBaseUrl = path.resolve(tsConfigDir, loadResult.baseUrl);
|
@nwalters512 Could you also add an entry for this PR in the CHANGELOG under unreleased heading ? With that it should be good to merge. |
|
Hey @nwalters512, would you mind adding this to |
|
I'm on it! Thanks for getting this reviewed. |
|
@jonaskello LGTM |
| }); | ||
|
|
||
| const successResult = result as ConfigLoaderSuccessResult; | ||
| assert.equal(successResult.absoluteBaseUrl, "/baz"); |
There was a problem hiding this comment.
Oops, this is using assert which is undefined.
@jonaskello Would be nice to run test CI on PRs!
There was a problem hiding this comment.
Good catch! Looks like my PR predated the move to Jest in #186. I can patch up this test if you aren't already working on that.
There was a problem hiding this comment.
I'll let you handle it, thanks!
There was a problem hiding this comment.
@aleclarson Yes, definitely would be nice to run the tests in CI :-). It used to work but perhaps it was broken by the move to github actions. I'll see if I can get that running again.
There was a problem hiding this comment.
PR with passing test suite: #211
configLoaderassumed thatbaseUrlwould always be relative path, but the TypeScript compiler allowsbaseUrlto be an absolute path as well. This PR updates theconfigLoaderto correctly computeabsoluteBaseUrlif thebaseUrlin the TypeScript config file is already absolute.Note that the same thing was already being done if
explicitParamswas provided.