fix: don't join absolute paths with baseUrl #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npdev453
changed the title
rattrayalex
reviewed
Jan 17, 2022
aleclarson
suggested changes
Apr 20, 2022
Co-authored-by: Alec Larson <1925840+aleclarson@users.noreply.github.com>
aleclarson
approved these changes
Apr 20, 2022
|
@npdev453 Could you also add an entry for this PR in the CHANGELOG under unreleased heading ? With that it should be good to merge. |
Done. |
|
@aleclarson I think this PR made some tests fail. Not sure if the tests are invalid or if something needs to be fixed. Could you take a look at it or perhaps we should just revert this PR? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes:
#181