forked from detekt/detekt
/
MandatoryBracesIfStatementsSpec.kt
217 lines (190 loc) · 5.83 KB
/
MandatoryBracesIfStatementsSpec.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
package io.gitlab.arturbosch.detekt.rules.style.optional
import io.gitlab.arturbosch.detekt.api.Config
import io.gitlab.arturbosch.detekt.test.assertThat
import io.gitlab.arturbosch.detekt.test.compileAndLint
import org.junit.jupiter.api.Nested
import org.junit.jupiter.api.Test
class MandatoryBracesIfStatementsSpec {
val subject = MandatoryBracesIfStatements(Config.empty)
@Nested
inner class `if statements which should have braces` {
@Test
fun `reports a simple if`() {
val findings = subject.compileAndLint(
"""
fun f() {
if (true)
println()
}
""".trimIndent()
)
assertThat(findings).hasSize(1)
assertThat(findings).hasTextLocations(14 to 16)
}
@Test
fun `reports a simple if with a single statement in multiple lines`() {
val findings = subject.compileAndLint(
"""
fun f() {
if (true) 50
.toString()
}
""".trimIndent()
)
assertThat(findings).hasSize(1)
}
@Test
fun `reports if-else with a single statement in multiple lines`() {
val findings = subject.compileAndLint(
"""
fun f() {
if (true) 50
.toString() else 50
.toString()
}
""".trimIndent()
)
assertThat(findings).hasSize(2)
assertThat(findings).hasTextLocations(11 to 13, 44 to 48)
}
@Test
fun `reports if-else`() {
val findings = subject.compileAndLint(
"""
fun f() {
if (true)
println()
else
println()
}
""".trimIndent()
)
assertThat(findings).hasSize(2)
assertThat(findings).hasTextLocations(14 to 16, 46 to 50)
}
@Test
fun `reports if-else with else-if`() {
val findings = subject.compileAndLint(
"""
fun f() {
if (true)
println()
else if (false)
println()
else
println()
}
""".trimIndent()
)
assertThat(findings).hasSize(3)
assertThat(findings).hasTextLocations(14 to 16, 51 to 53, 84 to 88)
}
@Test
fun `reports if with braces but else without`() {
val findings = subject.compileAndLint(
"""
fun f() {
if (true) {
println()
} else
println()
}
""".trimIndent()
)
assertThat(findings).hasSize(1)
assertThat(findings).hasTextLocations(50 to 54)
}
@Test
fun `reports else with braces but if without`() {
val findings = subject.compileAndLint(
"""
fun f() {
if (true)
println()
else {
println()
}
}
""".trimIndent()
)
assertThat(findings).hasSize(1)
assertThat(findings).hasTextLocations(14 to 16)
}
@Test
fun `reports else in new line`() {
val findings = subject.compileAndLint(
"""
fun f() {
if (true) println()
else println()
}
""".trimIndent()
)
assertThat(findings).hasSize(1)
assertThat(findings).hasTextLocations(14 to 16)
}
@Test
fun `reports only else body on new line`() {
val findings = subject.compileAndLint(
"""
fun f() {
if (true) println() else
println()
}
""".trimIndent()
)
assertThat(findings).hasSize(1)
assertThat(findings).hasTextLocations(34 to 38)
}
}
@Nested
inner class `if statements with braces` {
@Test
fun `does not report if statements with braces`() {
val code = """
fun f() {
if (true) {
println()
}
if (true)
{
println()
}
if (true) { println() }
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
}
@Nested
inner class `single-line if statements which don't need braces` {
@Test
fun `does not report single-line if statements`() {
val code = """
fun f() {
if (true) println()
if (true) println() else println()
if (true) println() else if (false) println() else println()
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
}
@Nested
inner class `multi-line when following an else statement without requiring braces` {
@Test
fun `does not report multi-line when`() {
val code = """
fun f(i: Int) {
if (true) {
println()
} else when(i) {
1 -> println(1)
else -> println()
}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
}
}