[BUG] With versioning enabled, "Show in Menu" does not work in page tree

[jrief]

Description

On the admin site, the page tree offers a checkbox named "Show in Menu". If djangocms-versioning is enabled, clicking on this checkbox shows an error.

Steps to reproduce

In the admin open the page tree:

then click on one of the checkboxes in the "Menu" column.

On top of the page tree this error message will appear:

Expected behaviour

I am well aware that enabling/disabling this setting is not possible with versioning enabled.
However, then this button shall be in read-only mode and not clickable.

Do you want to help fix this issue?

Yes, if we can agree on this: With djangocms-versioning enabled, the option show/hide in menu can only be changed through the page settings in their detail and not through the page tree.

• Yes, I want to help fix this issue and I will join #workgroup-pr-review on Slack to confirm with the community that a PR is welcome.
• No, I only want to report the issue.

[marksweb]

Yes that suggestion make sense to me. So hide the column if versioning is installed?

I don't know if there's a better way to do this with the cms config. But I think this is an area we all need to learn more about in order to do things the right way for v4, utilising all the features

@fabian do you have any thoughts?

[fsbraun]

Yes, I would support a change. Probably one that grays out checkboxes for non-draft versions.

Versioning implements a check framework, so that you can ask a model if you can do something, e.g. check_publish. (That might have been a nice thing to have had in the core.) You'll probably have to do check_modify for the Version object of the page content in the has_change_permission in the PageContent admin. This is subclassed in the cms_config.py file of versioning.

[fsbraun]

I think this needs a design decision to move the menu visibility to the page level for django CMS 4.2