Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PLACEHOLDER_CONF 'default_plugins' functionality removed. #7917

Closed
1 of 2 tasks
Ceesvanmook opened this issue May 13, 2024 · 2 comments · Fixed by #7919
Closed
1 of 2 tasks

[BUG] PLACEHOLDER_CONF 'default_plugins' functionality removed. #7917

Ceesvanmook opened this issue May 13, 2024 · 2 comments · Fixed by #7919

Comments

@Ceesvanmook
Copy link

Description

We have recently migrated to Django-cms 4, and the placeholder conf settings for default_plugins seem to have been completely removed.
When looking at the source code, and comparing this with older projects running on CMS 3 it seems to have been removed.

We have also found a git commit where the code has been removed:
eef5cbb

Despite it seemingly being removed, docs still have a reference to the PLACEHOLDER_CONF.default_plugins:
https://docs.django-cms.org/en/latest/reference/configuration.html#cms-placeholder-conf

Steps to reproduce

  1. Upgrade to DjangoCMS 4
  2. Create PLACEHOLDER_CONF with 'default_plugins' key.
  3. Nothing happens when rendering the placeholder

Expected behaviour

Fill the page with default plugins when the model is first created or the page is first rendered.

Actual behaviour

Nothing, as the code is removed.

Screenshots

When searching dependencies in DjangoCMS 3
image (1)

When searching dependencies in DjangoCMS 4
image

Additional information (CMS/Python/Django versions)

DjangoCMS version is 4.1.0

Do you want to help fix this issue?

  • Yes, I want to help fix this issue and I will join the channel #pr-reviews on the Discord Server to confirm with the community that a PR is welcome.
  • No, I only want to report the issue.
@Ceesvanmook Ceesvanmook changed the title [BUG] [BUG] PLACEHOLDER_CONF 'default_plugins' functionality removed. May 13, 2024
@fsbraun
Copy link
Sponsor Member

fsbraun commented May 14, 2024

@Ceesvanmook I created a PR in #7919. Can you do me a favor and install it locally for testing:

pip install git+https://github.com/fsbraun/django-cms@feat/default-plugins

Let me know any feedback!

@Ceesvanmook
Copy link
Author

@fsbraun thank you! I've installed it locally in my latest project and have done some testing with multiple models and placeholder configurations. On first glance, everything seems to be working as intended! I'll let you know if there are any updates on the matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants