Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrations for GenericForignKey relationships in the AbstractNoti… #348

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

YPCrumble
Copy link
Contributor

…fication model.

Fixes #347.

Note the because we're using the indexes setting instead of index_together, it appears this has auto-created a name for the existing index as well.

@YPCrumble
Copy link
Contributor Author

Note that this depends on #349

@YPCrumble
Copy link
Contributor Author

YPCrumble commented May 11, 2023

@AlvaroLQueiroz thanks for all your updates on this project! I'd love to get a review on this PR; essentially because GenericForeignKey doesn't automatically create an index, once we get more than a few million notifications it becomes extraordinarily slow to delete notifications for a given user. Happy to make changes or discuss if it's helpful!

@AlvaroLQueiroz
Copy link
Contributor

@YPCrumble Thanks man, I'm doing my best! :D

About the PR it's a great improvement, I liked it. But I believe it's better we release it on version 2.0.0 just to ensure that no one will have problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unindexed GenericForeignKey relationships are very slow to delete
2 participants